-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/better auth #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Auth
Caution
Breaking Changes
This PR migrates to use better auth for authentication and basic user management.
This needed some changes on the infrastructure
Benefits
Upgrade
To upgrade, make sure to
BETTER_AUTH_SECRET(see https://www.better-auth.com/docs/installation)BETTER_AUTH_URLpointing to your backend api url, e.g.https://tdev-api.gbsl.websiteALLOWED_ORIGINScontains your frontend url, e.g.https://tdev.gbsl.websiteAPP_NAME, since it is used as a prefix for session cookiesnode v22.15.0, you must probably update the buildpack on dokku withMSAL_CLIENT_SECREThttps://tdev-api.gbsl.websitethis would behttps://tdev-api.gbsl.website/api/auth/callback/microsoftCloses #45